Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Fix the welcome message and throw error when trying to cat a non-exis… #1032

Merged
merged 4 commits into from
Oct 16, 2017
Merged

Fix the welcome message and throw error when trying to cat a non-exis… #1032

merged 4 commits into from
Oct 16, 2017

Conversation

atvanguard
Copy link
Contributor

@atvanguard atvanguard commented Oct 1, 2017 •
edited
Loading

…tent file [Fixes #1031]

@dryajov
Copy link
Member

dryajov commented Oct 5, 2017

@atvanguard can you please add some tests verifying this works.

@atvanguard
Copy link
Contributor Author

@dryajov Added. Let me know if something needs to be improved.

@daviddias
Copy link
Member

@atvanguard Looking good. Mind checking my comment? Otherwise, LGTM

@daviddias daviddias self-requested a review October 13, 2017 16:32
daviddias
daviddias suggested changes Oct 13, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized now that tests are failing. @atvanguard could you check that?

@atvanguard
Copy link
Contributor Author

@diasdavid Incorporated the changes and increased the timeout for a test that was failing.

daviddias
daviddias approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, thanks @atvanguard :)

@daviddias daviddias merged commit 25fb390 into ipfs:master Oct 16, 2017
@atvanguard atvanguard mentioned this pull request Oct 16, 2017
Merged
@atvanguard atvanguard deleted the dev branch October 19, 2017 14:32
dryajov pushed a commit that referenced this pull request Oct 26, 2017
@atvanguard @dryajov
fix: fix the welcome message and throw error when trying to cat a non…
cc28451 
…-exis… (#1032)

* Fix the welcome message and throw error when trying to cat a non-existent file [Fixes #1031]

* Add tests

* Use CID instead of multihash, fix lint

* Increase cli init basic test timeout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atvanguard @dryajov @daviddias